Skip to content

Tests for constant propagation of StringBuffer.append() #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2019
Merged

Tests for constant propagation of StringBuffer.append() #5116

merged 2 commits into from
Sep 23, 2019

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Sep 18, 2019 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@danpoe
Remove ID of unimplemented string function
f53a598 
The string function with ID_cprover_string_concat_long_func was unimplemented
and will be obsolete when the functionality is handled by a model.
@danpoe
Add regression tests for constant propagation of StringBuffer.append()
6155f2a
allredj
allredj reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 6155f2a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/128192884

@codecov-io
Copy link

Codecov Report

Merging #5116 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5116      +/-   ##
===========================================
+ Coverage    69.71%   69.71%   +<.01%     
===========================================
  Files         1322     1322              
  Lines       109429   109428       -1     
===========================================
+ Hits         76287    76291       +4     
+ Misses       33142    33137       -5
Impacted Files Coverage Δ
...c/java_bytecode/java_string_library_preprocess.cpp 96.8% <ø> (-0.01%) ⬇️
src/solvers/flattening/boolbv_get.cpp 78.66% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74a8d8...6155f2a. Read the comment docs.

@danpoe danpoe merged commit b30b06a into diffblue:develop Sep 23, 2019
@danpoe danpoe deleted the feature/string-buffer-append branch June 2, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@JohnDumbell JohnDumbell JohnDumbell approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@thk123 thk123 Awaiting requested review from thk123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danpoe @codecov-io @smowton @allredj @JohnDumbell